ci: in-line build-image workflow into pr#4480
Merged
erikgb merged 1 commit intoweaveworks:mainfrom Jan 10, 2025
Merged
Conversation
erikgb
force-pushed
the
in-line-image-wf
branch
3 times, most recently
from
2401a59 to
914da8f
Compare
erikgb
force-pushed
the
in-line-image-wf
branch
from
914da8f to
eb5ef6b
Compare
casibbald
approved these changes
Jan 10, 2025
This was referenced Jan 15, 2025
This was referenced Jan 26, 2025
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
This inlines the build-image workflow into the PR workflow, making it a partial revert of #4468. Also trying to use similar settings as used when building release images. The workflow is mainly inlined to avoid triggering on Git tags. That could be fixed simpler by just modifying the
onconfiguration, but I think it's cleaner to have it inside the PR workflow. After I realized there is a special image build in the release workflow.Why was this change made?
When working on #4468, I didn't realize that there is a dedicated image build in the release workflow. We have decided to only make minor changes to the release process before cutting our first community releases.
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes