ci: correct image input to sign command#4488
Merged
erikgb merged 1 commit intoweaveworks:mainfrom Jan 11, 2025
Merged
Conversation
c80fe4a to
6918801
Compare
6918801 to
5255b47
Compare
tenstad
approved these changes
Jan 11, 2025
Contributor
tenstad
left a comment
There was a problem hiding this comment.
Not 100% sure this works, we'll have to see :D LGTM!
This was referenced Jan 15, 2025
This was referenced Jan 26, 2025
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
Another fix to #4483. This tries to supply the full image digest to the cosign commands. Extract from the last attempt to sign the image on the
mainbranch:So it seems like the job is trying to sign a simple DockerHub image tag - with a digest format. 🤠
Also adding an additional echo command - to see if the docker action can provide this information.
Why was this change made?
Try to make image signing work.
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes