ci: correct image sign verify command#4489
Merged
erikgb merged 1 commit intoweaveworks:mainfrom Jan 11, 2025
Merged
Conversation
tenstad
reviewed
Jan 11, 2025
| @@ -127,8 +127,8 @@ jobs: | |||
| - name: Verify the image signing | |||
| if: ${{ github.event_name != 'pull_request' && github.repository == 'weaveworks/weave-gitops' }} | |||
| run: | | |||
Contributor
There was a problem hiding this comment.
Change to > and remove indents instead, to avoid the backslashes?
Contributor
There was a problem hiding this comment.
Think you have to remove indents as well, that's the downside of >
Contributor
Author
There was a problem hiding this comment.
Then I actually prefer the backslash solution. Makes it easier to read, and simple to add additional commands.
erikgb
force-pushed
the
fix-image-sign-verify-command
branch
from
79ead18 to
a94090e
Compare
erikgb
force-pushed
the
fix-image-sign-verify-command
branch
from
a94090e to
c48182e
Compare
tenstad
approved these changes
Jan 11, 2025
This was referenced Jan 15, 2025
This was referenced Jan 26, 2025
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
Now the signing seems to work, but there is an error in the sign verification command which is corrected in this PR.
Why was this change made?
Make the
mainbranch CI green again.How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes