Fix proxy-middleware#4490
Merged
gusevda merged 2 commits intoweaveworks:mainfrom Jan 11, 2025
Merged
Conversation
PR [weaveworks#4413](weaveworks#4413) moved the proxy-middleware across major versions without migrations being applied to `.proxyrc.js` This affects redirecting API traffic from the front end to the backend server for both the `/v1` and `/oauth2` endpoints. This commit resolves that break by applying the necessary migration to `.proxyrc.js`
gusevda
approved these changes
Jan 11, 2025
This was referenced Jan 15, 2025
This was referenced Jan 26, 2025
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
PR #4413 moved the proxy-middleware across major versions without migrations being applied to
.proxyrc.jsThis affects redirecting API traffic from the front end to the backend server for both the
/v1and/oauth2endpoints.Why was this change made?
To resolve proxying requests to the backend when the backend server is on a different URL
How was this change implemented?
This commit resolves that break by applying the necessary migration to
.proxyrc.jsHow did you validate the change?
SKIP_UI_BUILD=1 tilt upto bring up the backend serviceyarn startto run the front end outside of tiltRelease notes
N/A - Restores original behaviour
Documentation Changes
N/A - Restores original behaviour