ci: reusable workflow for build-push image#4491
Merged
erikgb merged 1 commit intoweaveworks:mainfrom Jan 12, 2025
Merged
Conversation
31d0af2 to
cbea988
Compare
casibbald
approved these changes
Jan 12, 2025
cbea988 to
e10c4a4
Compare
This was referenced Jan 15, 2025
This was referenced Jan 26, 2025
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
This deduplicates the image build jobs for CI/PR and release.
Why was this change made?
Duplication is something we should try to avoid, but in this case it's even more important: I want to add image signing to the (existing) release workflow.
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes