Add dev resources to improve local testing capability#4511
Merged
erikgb merged 4 commits intoweaveworks:mainfrom Jan 13, 2025
Merged
Add dev resources to improve local testing capability#4511erikgb merged 4 commits intoweaveworks:mainfrom
erikgb merged 4 commits intoweaveworks:mainfrom
Conversation
mproffitt
changed the title
erikgb
requested changes
Jan 13, 2025
Contributor
There was a problem hiding this comment.
Thanks @mproffitt! Some minor suggestions from me. I would also appreciate if list of kustomize resource filenames are organized alphabetically and an empty line at the end of all files. But none of this is a blocker. 😸
- Resource alphabetical ordering - fix `-f` to become `-k` as otherwise specified (muscle memory) - split monitoring namespace to earlier in kustomize tree - drop `targetNamespace` from monitoring - podinfo targetNamespace remains as this enforces namespace to resources that do not have it set in upstream repo
Contributor
Author
|
I added an additional note to the readme in I'm happy to let this remain broken as it shows a "failed resource" in the UI which can be useful for testing. |
mproffitt
force-pushed
the
add-tools-resources
branch
from
31ae487 to
f46f5da
Compare
mproffitt
force-pushed
the
add-tools-resources
branch
from
ca6d2a4 to
d6b6511
Compare
This was referenced Jan 26, 2025
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Adds a base set of resources to apply to a kind cluster for local testing.
Why was this change made?
To improve testing capabilities when developing locally
How was this change implemented?
How did you validate the change?
By applying all resources under
tools/dev-resourceswithRelease notes
N/A
Documentation Changes
No.