test: replace http.Server with httptest.Server#4512
Merged
casibbald merged 1 commit intoweaveworks:mainfrom Jan 13, 2025
Merged
test: replace http.Server with httptest.Server#4512casibbald merged 1 commit intoweaveworks:mainfrom
casibbald merged 1 commit intoweaveworks:mainfrom
Conversation
casibbald
approved these changes
Jan 13, 2025
This was referenced Jan 15, 2025
This was referenced Jan 26, 2025
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4503
What changed?
Replace the use of
http.Serverwithhttptest.Serverinflow_test.go. Also removing the need for a new goroutine.Why was this change made?
I believe this should fix #4503, but since the tests only stall occasionally, I am not 100% sure. But I was able to reproduce the issue locally before this change, and not able after. 🙏
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes