Fix: Broken image links for container images#4557
Merged
mproffitt merged 1 commit intoweaveworks:mainfrom Jan 18, 2025
Merged
Conversation
gusevda
approved these changes
Jan 17, 2025
Whilst testing the react router change, I observed that links to container images on docker.io, ghcr and others resulted in a broken URL that didn't resolve to anywhere. It is likely that this functionality never worked as the image URL was never resolved back to its upstream counterpart as implemented in the `convertImage` function. This change is necessary to ensure container images link out to the correct location to engineers can better understand the continers running inside their cluster workloads. This change addresses the need by: wrapping container image links in the `convertImage` function
mproffitt
force-pushed
the
convert-image
branch
from
b15ef52 to
0fc90eb
Compare
This was referenced Jan 26, 2025
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst testing the react router change, I observed that links to container images on docker.io, ghcr and others resulted in a broken URL that didn't resolve to anywhere.
It is likely that this functionality never worked as the image URL was never resolved back to its upstream counterpart as implemented in the
convertImagefunction.This change is necessary to ensure container images link out to the correct location to engineers can better understand the continers running inside their cluster workloads.
This change addresses the need by: wrapping container image links in the
convertImagefunction