Replace yaml library with js-yaml#4565
Merged
gusevda merged 1 commit intoweaveworks:mainfrom Jan 18, 2025
Merged
Conversation
erikgb
reviewed
Jan 18, 2025
Contributor
erikgb
left a comment
erikgb
left a comment
There was a problem hiding this comment.
LGTM, but someone with more frontend experience should review this. 😉
erikgb
force-pushed
the
replace-yaml-library
branch
from
2669a01 to
4602ebf
Compare
erikgb
force-pushed
the
replace-yaml-library
branch
from
4602ebf to
ec32dfc
Compare
This was referenced Jan 26, 2025
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
In this PR:
yamllibrary was replaced withjs-yamllibrary;parcel build;Why was this change made?
There is a problem with
yamlpackage that causes builds for production to fail. As a temporal solution, parcel scope hoisting was disabled in the PR. This PR fixes production builds.How did you validate the change?
Tested locally by running with
yarn startand separately withtilt up.