ci(lint): enable @typescript-eslint/ban-ts-comment eslint rule#4566
Merged
erikgb merged 1 commit intoweaveworks:mainfrom Jan 19, 2025
Merged
ci(lint): enable @typescript-eslint/ban-ts-comment eslint rule#4566erikgb merged 1 commit intoweaveworks:mainfrom
erikgb merged 1 commit intoweaveworks:mainfrom
Conversation
erikgb
force-pushed
the
fix-lint-ts-comment
branch
3 times, most recently
from
f72aa60 to
46b4578
Compare
mproffitt
approved these changes
Jan 19, 2025
erikgb
force-pushed
the
fix-lint-ts-comment
branch
from
46b4578 to
cc430b2
Compare
This was referenced Jan 26, 2025
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
Enable
@typescript-eslint/ban-ts-commentrule, one of the thetypescript-eslintrecommended rules.Why was this change made?
Besides being recommended, I think the rule makes a lot of sense. Now a developer must add a comment to why Typescript error is ignored.
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes