Skip to content

ci: improve python setup in nightly workflow#4619

Merged
erikgb merged 1 commit intoweaveworks:mainfrom
erikgb:python-nightly
Jan 25, 2025
Merged

ci: improve python setup in nightly workflow#4619
erikgb merged 1 commit intoweaveworks:mainfrom
erikgb:python-nightly

Conversation

@erikgb
Copy link
Copy Markdown
Contributor

@erikgb erikgb commented Jan 25, 2025

Closes

What changed?

  • Create a pip requirements file to manage Python dependencies required for the nightly (Playwright) workflow.
  • Upgrade Python to 3.12 (not the latest, but pretty stable).
  • Introduce caching of pip dependencies in the workflow.

Why was this change made?

This change was triggered by alerts about unpinned dependencies from our security scanner. But I also believe this setup is cleaner and more performant (caching).

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@erikgb erikgb requested a review from casibbald January 25, 2025 11:22
@erikgb erikgb merged commit 5e22fca into weaveworks:main Jan 25, 2025
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants