test(go): remove unused controller-runtime Manager#4626
Merged
erikgb merged 1 commit intoweaveworks:mainfrom Jan 26, 2025
Merged
test(go): remove unused controller-runtime Manager#4626erikgb merged 1 commit intoweaveworks:mainfrom
erikgb merged 1 commit intoweaveworks:mainfrom
Conversation
erikgb
force-pushed
the
cleanup-k8s-test
branch
from
c3eef86 to
f1678f4
Compare
erikgb
force-pushed
the
cleanup-k8s-test
branch
from
f1678f4 to
7dfb44d
Compare
casibbald
approved these changes
Jan 26, 2025
This was referenced Jan 26, 2025
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
The primary change in this PR is removing an unused controller-runtime
Manager. I have no idea why the test setup was created this way, but we don't need to create a Manager (heavy) just to create a controller-runtimeClient.In addition, I made all use of the test-helper consistent (stopping testEnv).
Also improving a flaky test with Ginkgo
Eventually- as it was bugging me while verifying this change. 🤠Why was this change made?
Still trying to dig into the occasionally blocked tests.
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes