Skip to content

ci(release): improve goreleaser configuration file#4683

Merged
erikgb merged 1 commit intoweaveworks:mainfrom
erikgb:fix-goreleaser-conf
Feb 4, 2025
Merged

ci(release): improve goreleaser configuration file#4683
erikgb merged 1 commit intoweaveworks:mainfrom
erikgb:fix-goreleaser-conf

Conversation

@erikgb
Copy link
Copy Markdown
Contributor

@erikgb erikgb commented Feb 4, 2025

Closes

What changed?

Fixes issues reported by goreleaser check.

Before:

$ goreleaser check
  • failed to set GOMAXPROCS                         error=open /mnt/wsl/var/lib/docker/overlay2/23566a852a3049a969d29135dcd72d6ea1666428956eb4497f3b3f6ecfdeb13c/merged/sys/fs/cgroup/cpu/cpu.cfs_quota_us: permission denied
  • only configurations files on  version: 2  are supported, yours is  version: 0 , please update your configuration
  • checking                                 path=.goreleaser.yml
  • DEPRECATED:  archives.format  should not be used anymore, check https://goreleaser.com/deprecations#archivesformat for more info
  • .goreleaser.yml                                  error=configuration is valid, but uses deprecated properties
  ⨯ command failed                                   error=1 out of 1 configuration file(s) have issues

After:

$ goreleaser check
  • failed to set GOMAXPROCS                         error=open /mnt/wsl/var/lib/docker/overlay2/23566a852a3049a969d29135dcd72d6ea1666428956eb4497f3b3f6ecfdeb13c/merged/sys/fs/cgroup/cpu/cpu.cfs_quota_us: permission denied
  • checking                                 path=.goreleaser.yml
  • 1 configuration file(s) validated
  • thanks for using GoReleaser!

Why was this change made?

It seems like binaries were not built when attempting to build a release candidate. I dunno if this will fix it, but I think this is an improvement anyway.

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@erikgb erikgb requested a review from a team February 4, 2025 18:01
@erikgb erikgb force-pushed the fix-goreleaser-conf branch from 8f4587c to 4500a04 Compare February 4, 2025 18:06
Copy link
Copy Markdown
Contributor

@mproffitt mproffitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@erikgb erikgb merged commit 1108733 into weaveworks:main Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants