Skip to content

Fix incorrect httpPort assignment and other issues in src/main/java/io/weaviate/client6/v1/api/Config.java #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bevzzz merged 3 commits into from
Jul 25, 2025
Merged

Fix incorrect httpPort assignment and other issues in src/main/java/io/weaviate/client6/v1/api/Config.java #426

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0961794
fix: #425
yazan-abu-obaideh Jul 23, 2025
313a564
fix: #425
yazan-abu-obaideh Jul 24, 2025
6fdf992
fix: #425
Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/io/weaviate/client6/v1/api/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public static Config of(Function<Custom, ObjectBuilder<Config>> fn) {
return fn.apply(new Custom()).build();
}

public Config(Builder<?> builder) {
private Config(Builder<?> builder) {
this(
builder.scheme,
builder.httpHost,
Expand All @@ -42,7 +42,7 @@ public GrpcChannelOptions grpcTransportOptions() {
return new GrpcChannelOptions(scheme, grpcHost, grpcPort, headers, tokenProvider);
}

abstract static class Builder<SELF extends Builder<SELF>> implements ObjectBuilder<Config> {
private abstract static class Builder<SELF extends Builder<SELF>> implements ObjectBuilder<Config> {
protected String scheme;

protected String httpHost;
Expand Down Expand Up @@ -158,8 +158,8 @@ public static class Custom extends Builder<Custom> {
* <strong>443</strong> for HTTPS connection and <strong>80</strong> for HTTP.
*/
public Custom scheme(String scheme) {
httpPort(scheme == "https" ? 443 : 80);
grpcPort(scheme == "https" ? 443 : 80);
httpPort("https".equals(scheme) ? 443 : 80);
grpcPort("https".equals(scheme) ? 443 : 80);
return super.scheme(scheme);
}

Expand All @@ -169,7 +169,7 @@ public Custom httpHost(String httpHost) {
}

public Custom httpPort(int port) {
this.grpcPort = port;
this.httpPort = port;
return this;
}

Expand Down