feat(deps): upgrade http-proxy-middleware to v4.0.0-beta.2#7436
Conversation
chenjiahan
changed the title
Deploying rsbuild with
|
| Latest commit: |
2356ec6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82e8a4d1.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://chenjiahan-upgrade-http-prox.rsbuild-v2.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the http-proxy-middleware dependency to version 4.0.0-beta.2, removes the http-proxy patch, and updates the migration documentation. Feedback indicates a critical Node.js version mismatch between the new dependency and the project's supported versions, which may lead to installation failures. Additionally, the documentation links for the migration guides need to be corrected and expanded to cover both v3 and v4 transitions.
There was a problem hiding this comment.
Pull request overview
Upgrades @rsbuild/core’s proxy middleware dependency to http-proxy-middleware@4.0.0-beta.2, removes the no-longer-needed http-proxy@1.18.1 patch, and updates the v1→v2 upgrade docs to reflect the new proxy middleware version.
Changes:
- Bump
http-proxy-middlewarefrom^3.0.5to^4.0.0-beta.2(and update lockfile accordingly). - Remove the
http-proxy@1.18.1patched dependency and delete the patch file. - Update EN/ZH upgrade guides to mention v4 (but still referencing v3 migration details).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/en/guide/upgrade/v1-to-v2.mdx | Updates proxy middleware upgrade text to v4 (link text still points to v3 section). |
| website/docs/zh/guide/upgrade/v1-to-v2.mdx | Same as EN, in Chinese (link/anchor still v3). |
| packages/core/package.json | Bumps http-proxy-middleware version used by @rsbuild/core. |
| pnpm-workspace.yaml | Removes http-proxy@1.18.1 from patchedDependencies. |
| pnpm-lock.yaml | Lockfile updates for http-proxy-middleware v4 + removal of http-proxy patch, plus transitive changes. |
| patches/http-proxy@1.18.1.patch | Deletes the obsolete patch file. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2356ec650c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
chenjiahan
deleted the
chenjiahan/upgrade-http-proxy-middleware-v4-beta-2
branch
Summary
http-proxy-middlewarein@rsbuild/corefrom^3.0.5to^4.0.0-beta.2, which brings in the upstreamhttpxyrefactor and lets us remove the oldhttp-proxy@1.18.1patch.Related Links
http-proxyw/httpxychimurai/http-proxy-middleware#1160