[Import Maps] Import tests #19685
Merged
[Import Maps] Import tests #19685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 15, 2019
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
Already reviewed downstream.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1842928
branch
7 times, most recently
from
14a3cee to
45e3e5a
Compare
This CL imports post-#176 upstream reference implementation's tests into wpt/import-maps/imported/, and executes them under virtual/import-maps-without-builtin-modules/. The pre-#176 existing tests are still left under wpt/import-maps/builtin-support.tentative/imported/, which are excluded by this CL from virtual/import-maps-without-builtin-modules. To match with the expectation of post-#176 tests, this CL modifies ImportMap::ToString() to output strings (not single-element arrays) as right hand side. WICG/import-maps#176 Bug: 990561, 1010751 Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842928 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#706637}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1842928
branch
from
45e3e5a to
551f731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.
The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.
To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.
WICG/import-maps#176
Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842928
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706637}