Revert "feat: Advanced Video Editor Implementation, Native WGC Integration, and AI Auto-Captions"#124
Merged
webadderall merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
…ation, and AI Auto-Captions"
|
Caution Review failedThe pull request is closed. Warning
|
| Cohort / File(s) | Summary |
|---|---|
Whisper Model Simplification electron/electron-env.d.ts, electron/preload.ts, electron/ipc/handlers.ts |
Replaced multi-model Whisper APIs (getWhisperModelStatus, downloadWhisperModel, etc.) with single-model variants (getWhisperSmallModelStatus, downloadWhisperSmallModel, etc.); removed model name parameters from all Whisper IPC contracts and responses. |
Auto-Captions Streamlining electron/electron-env.d.ts, electron/ipc/handlers.ts, src/components/video-editor/SettingsPanel.tsx, src/components/video-editor/VideoEditor.tsx |
Removed time-range-based caption generation (durationMs, startTimeMs, generationRange); simplified flow from segmented transcription with progress events to single-pass full-video captioning; removed onAutoCaptionProgress and onAutoCaptionChunk event listeners. |
Audio Controls & Master Audio Removal src/components/video-editor/AudioSettingsPanel.tsx, src/components/video-editor/SettingsPanel.tsx, src/components/video-editor/VideoEditor.tsx, src/components/video-editor/editorPreferences.ts, src/components/video-editor/projectPersistence.ts, src/components/video-editor/types.ts, src/lib/exporter/audioEncoder.ts, src/lib/exporter/videoExporter.ts, src/lib/exporter/types.ts |
Deleted AudioSettingsPanel component entirely; removed master audio mute/solo/volume state and per-region fade controls; simplified audio export to volume-only without master mixing; removed persisted preferences for audio controls. |
Blur Annotation Removal src/components/video-editor/AnnotationOverlay.tsx, src/components/video-editor/AnnotationSettingsPanel.tsx, src/components/video-editor/types.ts, src/lib/exporter/annotationRenderer.ts |
Removed "blur" annotation type and blurIntensity field from annotation regions; eliminated blur UI controls and rendering logic; reduced supported annotation types to `"text" |
Timeline Editor & Caption Row Removal src/components/video-editor/timeline/TimelineEditor.tsx, src/components/video-editor/timeline/Item.tsx, src/components/video-editor/timeline/ItemGlass.module.css, src/components/video-editor/timeline/Row.tsx, src/components/video-editor/timeline/TimelineWrapper.tsx, src/components/video-editor/timeline/KeyframeMarkers.tsx |
Removed master audio row, caption rows, and time-selection UI from timeline; eliminated "caption" variant from items; removed audio waveform display, mute/solo/fade overlays; simplified item interaction by removing selection-based drag/resize and timeline "select" mode; narrowed TimelineRenderItem.variant to 'zoom' | 'trim' | 'annotation' | 'speed' | 'audio'. |
Video Playback & Export Simplification src/components/video-editor/VideoPlayback.tsx, src/components/video-editor/videoPlayback/videoEventHandlers.ts |
Removed timeSelection prop and seek() method from playback; eliminated time-selection-aware pause/seek logic; removed time-selection ref handling from video event handlers. |
Build Script & CMake Cleanup scripts/build-cursor-monitor.mjs, scripts/build-whisper-runtime.mjs, scripts/build-windows-capture.mjs, .gitignore |
Removed local CMake bundling references (.cmake_ext/) from CMake discovery logic; normalized Windows build script formatting; cleaned up Git ignore patterns. |
Native Windows Capture Monitor Matching electron/native/wgc-capture/src/main.cpp, electron/native/wgc-capture/src/monitor_utils.cpp, electron/native/wgc-capture/src/monitor_utils.h, electron/native/bin/win32-x64/whisper-runtime.json |
Removed display-bounds-based fallback monitor matching (findMonitorByBounds, displayX/Y/W/H config fields); monitor selection now relies solely on displayId lookup; removed unused includes and conversion helpers; deleted Whisper runtime manifest file. |
IPC & Window Communication Hardening electron/windows.ts |
Switched from guarded if (!win.isDestroyed()) to optional chaining in IPC sends, relying on webContents availability checks. |
Configuration & Utilities Cleanup electron-builder.json5, package.json, src/utils/audioWaveform.ts, src/index.css |
Removed top-level copyright field from electron-builder config; fixed artifact naming in Windows NSIS build; removed typecheck script; deleted audio waveform generation utility; removed WebKit scrollbar styling. |
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~50 minutes
Possibly related PRs
- feat: Advanced Video Editor Implementation, Native WGC Integration, and AI Auto-Captions #122 — Directly conflicting: this PR removes multi-model Whisper, audio controls, blur annotations, and caption range selection features that were added in PR#122, making these two PRs inverse operations on the same APIs and components.
- Add custom cursor packs and harden native postinstall build flow #111 — Both PRs modify CMake discovery in build scripts and
.gitignoreentries, removing local.cmake_extdirectory support. - feat(editor): add cursor sway, HUD capture controls, and persistent prefs #38 — Shared code paths in editor props, playback surface, and exporter configuration (SettingsPanel, VideoEditor, VideoPlayback, projectPersistence, videoExporter).
Suggested labels
Checked
🐰 With whispers now one small and true,
And audio controls bid adieu,
The blur is gone, the captions fade,
Simplicity's the grand parade!
Less code to tend, a lighter load—
A rabbit hops down cleaner roads! 🐇✨
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
revert-122-main
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #122 as it seems to be AI slop and adds many code changes not included in PR desc
Summary by CodeRabbit