Language server refactoring #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webdevred
force-pushed
the
language-server-refactoring
branch
from
d6aae12 to
15112be
Compare
webdevred
force-pushed
the
language-server-refactoring
branch
from
bc6f5bf to
dcea534
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
webdevred
force-pushed
the
language-server-refactoring
branch
4 times, most recently
from
2aa276d to
2414fa5
Compare
- Added new Cabal test suite `jbeam-language-server-test` for all LSP-related tests. - Moved `WorkspaceLspSpec` to `test-extra/language-server/` and removed CPP guards. - Added new `DocumentStoreSpec` with tests for open, update, delete, and reset. - Introduced `resetStore` in `Services.DocumentStore` for clean test isolation. - Refactored `Handlers/Formatting`: - Simplified response logic with `sendNoUpdate`. - Rewrote `runFormatNode` to return `Maybe TextEdit` for cleaner control flow. - Updated `package.yaml` to reflect the new test suite. - Removed LSP test stubs and flags from `jbeam-edit-test`. - Added `.dir-locals.el` for convenient Emacs REPL setup. This isolates LSP tests from core `jbeam-edit` tests, simplifies configuration, and improves overall test maintainability.
- Moved `app` -> `exe/jbeam-edit` and `app-extra/jbeam-lsp-server` -> `exe/jbeam-lsp-server`. - Adjusted `hs-source-dirs` in `jbeam-edit.cabal` and `package.yaml` to match new locations.
webdevred
force-pushed
the
language-server-refactoring
branch
from
2414fa5 to
2cb2828
Compare
webdevred
force-pushed
the
language-server-refactoring
branch
from
2cb2828 to
92cf23f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jbeam-lsp-serverin Cabal and GitHub Actions buildsjbeam-lsp-server.exealongsidejbeam-edit.exeexe/(exe/jbeam-edit,exe/jbeam-lsp-server)Handlers/Formattingfor cleaner edit handling and error reportingresetStoretoServices.DocumentStorefor test isolationjbeam-language-server-testDocumentStoreand LSP formatting integrationtest/WorkspaceLspSpec.hs_jbeam-test-commonshared config