Support removing </p>...<p> from content inside shortcodes#47
Merged
Conversation
mpdude
changed the title
</p>...<p> from content inside shortcodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When embedding shortcodes in HTML markup (for example, writing shortcodes in an editor like CKEditor or TinyMCE) and using opening/closing shortcodes with content in between, dangling
</p>...<p>tags may remain inside the shortcode.This PR adds a new
RemovePendingParagraphElementsInsideShortcodeEventHandlerto remove these tags.To avoid breaking BC, this feature has to be enabled by setting the
remove_pending_inner_paragraph_elementsconfig setting.Additionally, to make it easier to register multiple event listeners in the
\Thunder\Shortcode\EventContainer\EventContainer, a newwebfactory.shortcode.event_listenertag is added to the container. It must be used with aeventattribute value to indicate the event to subscribe to.