[FEATURE] Add API to get server configuration#124
Merged
gotchazipc merged 1 commit intowebida:masterfrom Nov 5, 2015
Merged
Conversation
[DESC.] - add API `GET:/webida/api/app/configs` for getting information of system apps and feature enables. - seperate `App` model from `app-manager` module - remove useless package, `connect-mongo`, from `pacakge.json` - add a feature enabling JSONP response for this new API - fix some bugs
Contributor
There was a problem hiding this comment.
Do we have 'root app' in DB? Why do we need this? I think we can simplify App.js more, but not an urgent task.
Contributor
Author
There was a problem hiding this comment.
I think that managing on rootApp is no more needed. It's good to remove this method.
gotchazipc
added a commit
that referenced
this pull request
Nov 5, 2015
[FEATURE] Add API to get server configuration
Contributor
|
Looks Good. I'll follow up fixing webidaCookieSetter() in app.js and new configuration property conf.useReverseProxy, boolean. (Hope you remember what we've done in my little test VM) Let's move to documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[DESC.]
GET:/webida/api/app/configsfor getting information of system apps and feature enables.Appmodel fromapp-managermoduleconnect-mongo, frompacakge.json