[PR] extract data directories out of server souces#132
Merged
kyungmi merged 4 commits intowebida:masterfrom Nov 9, 2015
gotchazipc:master
Merged
[PR] extract data directories out of server souces#132kyungmi merged 4 commits intowebida:masterfrom gotchazipc:master
kyungmi merged 4 commits intowebida:masterfrom
gotchazipc:master
Conversation
added 2 commits
November 7, 2015 12:54
- added new env. var WEBIDA_HOME, with hardcoded default /home/webida - added upstart configurations & sudoer file template - fixed some .gitignore files - removed -s rootfs option in lxc container - removed some obsolute configuration properties - added many comments to default-conf.js
- Now configuration respects NODE_ENV and WEBIDA_HOME env variable. - (default-)conf.js now have basic sanity check feature - using WEBIDA_HOME, most of dirs placed in server source is moved out to some safer place. So, developers can handle webida source directory with their own accout used for cloning. (Yey!) - Wiki has detailed guide how to set-up log, fs, apps dir before install - fixed upstart configurations with WEBIDA_HOME - fixed upstart configurations author to Webida Team
gotchazipc
changed the title
gotchazipc
changed the title
Contributor
There was a problem hiding this comment.
Removing all configuration file is safe in any case of running lxc-execute?
Contributor
Author
There was a problem hiding this comment.
It's safe. because,
- lxc networking configurations are saved in /etc/lxc & /etc/default/lxc-net
- rootfs path is saved in container configuration (/home/webida/lxc/webida/config) already. It's better to respect the container config than overriding it with conf.js
3)${server-source-top}/fs/lxc, containing rootfs & container configuration, is not a part of our code but user's environment, which should be created while installing pre-requisites.
added 2 commits
November 9, 2015 18:28
- checked with jshint & eslint
- removed backward-compatibilty for conf.services.fs.lxc (now, should always use conf.services.fs.container.lxc, instead.)
kyungmi
added a commit
that referenced
this pull request
Nov 9, 2015
[PR] extract data directories out of server souces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still writing guides on wiki. (resolves #131)