[IMPROVEMENT] Change the terminal protocol#136
Merged
gotchazipc merged 2 commits intowebida:masterfrom Nov 10, 2015
Merged
Conversation
[DESC.] - IDE terminal module is changed from terminal.js to term.js. So adjust the protocol to the new client. - Remove the `socket.io-stream` dependency from `package.json` Thanks to WSDK team. Related with the commit#b57958795c3104f987edb78d2a5db5044cbb45b1
gotchazipc
added a commit
that referenced
this pull request
Nov 10, 2015
[IMPROVEMENT] Change the terminal protocol Good Job. (Wrote a short comment about cleaning up terminal service logic, just read & forget :P) We may need more logs on spawning & killing pty, especially on error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[DESC.]
socket.io-streamdependency frompackage.jsonThanks to WSDK team.
Related with the commit#b57958795c3104f987edb78d2a5db5044cbb45b1
[ISSUES]
webida/webida-client#459
webida/webida-client#533
webida/webida-client#534