[BUGFIX] (webida/webida-client#683) fix ACL bug#137
Merged
gotchazipc merged 5 commits intowebida:masterfrom Nov 16, 2015
Merged
[BUGFIX] (webida/webida-client#683) fix ACL bug#137gotchazipc merged 5 commits intowebida:masterfrom
gotchazipc merged 5 commits intowebida:masterfrom
Conversation
[DESC.] - Access control had no meaning because of SQL misusing. - Putting number 0 in 'IN' statement makes unsuspected result(getting almost all rows that has a field filled with a string value in result).
Contributor
Author
|
README! This SHOULD NOT be merged before fixing some related webida-dashboard's logic. |
added 3 commits
November 16, 2015 17:21
[DESC.]
- provide more specific, limited auth policy for a user
- check authorization on more specific resource on auth server
- clean up duplications on code
[DB Migration]
And you SHOULD apply below SQL for migration.
```
update mem_policy p
inner join mem_user u on u.user_id = p.owner_id
set p.resource = concat('["auth:', p.owner_id , '"]')
where u.type = 0
and p.name = 'defaultAuth';
```
gotchazipc
added a commit
that referenced
this pull request
Nov 16, 2015
[BUGFIX] (webida/webida-client#683) fix ACL bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BUGFIX] fix ACL bug
[DESC.]
[TASK] remove useless dependencies
[BUGFIX] assign more safe, detailed default auth policy to users
[DESC.]
[DB Migration]
And you SHOULD apply below SQL for migration.