#110 Cache & Node 4.2 #144
Merged
kyungmi merged 8 commits intowebida:masterfrom Nov 19, 2015
gotchazipc:cache
Merged
Conversation
Contributor
|
@gotchazipc A wrong commit(b080418) was mixed in this PR. Can you try to rebase your commits? |
- introduced redis in package.json - refactoring in auth-manager.js - removed deprecated authMgr.verifyToken - replaced with ensureLogin - renamed verifySesssion to getUserInfoByToken
- changed node-redis to ioredis (faster & more powerful) - sorted dependency list & pull '*' versioned packages - added cache-related configuration in default-conf.js - fixed some bugs in auth-manager.js - added simple test for cache.js
- removed test/conf, replaced with symbolic link - fixed bugs of Cache constructor - fixed bugs in cache test
- implemented token read/write logics - merged checkAuthorization & checkAuthorize - fixed some typos
- many bugs are fixed - added some logs in userdb, acl-manager, fs-manager - fixed log timestamp format bug - hh --> HH - fixed default-conf.js sanity checker for right propery paths.
- changed auth & common - we may need to change other modules, later
- missed ',' after sorting dependencies. sorry.
Contributor
Author
|
sorry for jshint errors. we may fix the errors later, after merging. |
kyungmi
pushed a commit
that referenced
this pull request
Nov 19, 2015
Changed function names look good:+1:
Contributor
|
Were there any problems fixing jshint error before merging? |
Merged
Contributor
|
@wcho There were warnings related with ES6 from jshint checker. We are going to fix it with the jenkins server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redis is coming... & we'll move on to node 4.2, as documented.