Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

Implement ops for style transfer model#36

Merged
huningxin merged 11 commits intowebmachinelearning:masterfrom
huningxin:style_transfer_ops
Mar 17, 2021
Merged

Implement ops for style transfer model#36
huningxin merged 11 commits intowebmachinelearning:masterfrom
huningxin:style_transfer_ops

Conversation

@huningxin
Copy link
Contributor

fix #34

@BruceDai , PTAL. As this PR includes the API change of conv2d and pool2d, the cts needs to be fixed. Please help fix them. I excluded the cts in the npm test script. Once you fix the cts, please re-include them.

@Honry please also take a look from style transfer sample perspective.

Thanks!

@huningxin huningxin requested a review from BruceDai March 16, 2021 08:30
@BruceDai
Copy link
Collaborator

the cts needs to be fixed. Please help fix them. I excluded the cts in the npm test script. Once you fix the cts, please re-include them.

@huningxin Yes, I will fix cts part, thanks.

Copy link
Collaborator

@BruceDai BruceDai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huningxin, LGTM.

I verified this pr, all 431 tests passed by running in node.js and in Chrome browser.

@huningxin
Copy link
Contributor Author

@BruceDai I also fixed the build-docs script according to typedoc dependency update. And similar to webmachinelearning/webnn#151, I also fixed this repo. Please take another look.

@huningxin
Copy link
Contributor Author

cc @anssiko

@huningxin huningxin requested a review from anssiko March 16, 2021 11:07
Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Honry
Copy link
Contributor

Honry commented Mar 16, 2021

@huningxin, thanks! LGTM, all ops that required by style transfer sample have been included in this PR.

@BruceDai
Copy link
Collaborator

@BruceDai I also fixed the build-docs script according to typedoc dependency update. And similar to webmachinelearning/webnn#151, I also fixed this repo. Please take another look.

@huningxin LGTM, thanks.

@huningxin
Copy link
Contributor Author

Thanks for the review. Let's merge it and unlock the development of style transfer sample.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the changes/additions of ops for style transfer models

4 participants