Skip to content

Add the spec text and examples for MLGraph.compute#147

Merged
huningxin merged 6 commits intowebmachinelearning:masterfrom
huningxin:compute_spec
Apr 1, 2021
Merged

Add the spec text and examples for MLGraph.compute#147
huningxin merged 6 commits intowebmachinelearning:masterfrom
huningxin:compute_spec

Conversation

@huningxin
Copy link
Contributor

@huningxin huningxin commented Feb 24, 2021

@wchao1115 @pyu10055 @anssiko , PTAL.

Hopefully, it would fix #140 @cynthia, please also take a look.

Another note is, for the spec of ML device interactions, I found the timelines of WebGPU spec is quite useful. So I adapted and included it in this PR.


Preview | Diff

@anssiko
Copy link
Member

anssiko commented Feb 25, 2021

@huningxin, thank you for this substantial PR. LGTM for the general direction.

I suggest we seek review from WebGPU folks for the timeline convention we've borrowing from the WebGPU spec. @kainino0x may be interested in taking a quick look on that particular aspect.

@huningxin
Copy link
Contributor Author

I suggest we seek review from WebGPU folks for the timeline convention we've borrowing from the WebGPU spec. @kainino0x may be interested in taking a quick look on that particular aspect.

Absolutely, also cc @Kangz

@huningxin
Copy link
Contributor Author

Thanks for review, also @RafaelCintron for comments.

@huningxin
Copy link
Contributor Author

I'll rework this PR due to #149 and potential change being discussed in #149 (comment)

@huningxin huningxin marked this pull request as draft March 17, 2021 02:27
@wchao1115
Copy link
Collaborator

@huningxin Can you update the PR to reflect the new naming in the spec?

@huningxin huningxin marked this pull request as ready for review March 29, 2021 08:50
@huningxin
Copy link
Contributor Author

@huningxin Can you update the PR to reflect the new naming in the spec?

@wchao1115 , done. Actually reworked this PR regarding to #149 .

Please note this PR only specifies the MLGraph.compute algorithm steps for default context with inputs/outputs are ArrayBufferView. An issue was added inline into the spec that tracks the algorithm steps for WebGL/WebGPU interops.

Please take another look. Thanks!

@huningxin huningxin changed the title Add the spec text and examples for Compilation.compute Add the spec text and examples for MLGraph.compute Mar 29, 2021
@huningxin
Copy link
Contributor Author

The conflict was resolved, I am going to merge it, thanks for the review and approvals.

@huningxin huningxin merged commit d784042 into webmachinelearning:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NamedOutput mechanism clarification

4 participants