Skip to content

Fix #308: refer to MLContext validation steps from MLGraphBuilder#332

Merged
anssiko merged 2 commits intowebmachinelearning:mainfrom
zolkis:graphbuilder-constructor-update
Jan 24, 2023
Merged

Fix #308: refer to MLContext validation steps from MLGraphBuilder#332
anssiko merged 2 commits intowebmachinelearning:mainfrom
zolkis:graphbuilder-constructor-update

Conversation

@zolkis
Copy link
Collaborator

@zolkis zolkis commented Jan 23, 2023

Fix #308: refer to MLContext validation steps from MLGraphBuilder constructor

Minor change, adds reference to missing algorithm.

@anssiko PTAL


Preview | Diff

…MLGraphBuilder constructor

Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>
@zolkis
Copy link
Collaborator Author

zolkis commented Jan 23, 2023

Looks like my editor stumbled upon line endings (trailing spaces) here as well.
Fortunately the diff is usable.

Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Protip: you can hide whitespace in GH diffs with w=1 e.g. https://github.com/webmachinelearning/webnn/pull/332/files?diff=unified&w=1

Co-authored-by: Anssi Kostiainen <anssi.kostiainen@intel.com>
@anssiko
Copy link
Member

anssiko commented Jan 24, 2023

Thanks @zolkis!

I'll merge this minor change to allow the WG to focus on additional work ahead.

@anssiko anssiko merged commit 817c5a5 into webmachinelearning:main Jan 24, 2023
github-actions bot added a commit that referenced this pull request Jan 24, 2023
SHA: 817c5a5
Reason: push, by anssiko

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate MLContext

2 participants