Wording: Use shorter possessive form for abstract object properties#565
Merged
anssiko merged 7 commits intowebmachinelearning:mainfrom Feb 15, 2024
inexorabletash:wording-possessive
Merged
Wording: Use shorter possessive form for abstract object properties#565anssiko merged 7 commits intowebmachinelearning:mainfrom inexorabletash:wording-possessive
anssiko merged 7 commits intowebmachinelearning:mainfrom
inexorabletash:wording-possessive
Conversation
MLOperands have a rank; the shape just has a size.
Old and busted: ... the [=property=] of |object| ... New hotness: ... |object|'s [=property=] ... Discussed in #555 (comment)
I noticed "then then" in the previous commit and searched for similar glitches to fix.
* Erroneously referencing descriptor properties, but directly against an operand. This can be fixed by using the shape and dataType shortcuts. (6 cases) * Simplifications where an operand's shape shortcut could be used. (3 cases)
fdwr
approved these changes
Feb 15, 2024
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
✨🔥 Farewell "the the" and "as as".
anssiko
approved these changes
Feb 15, 2024
Member
|
@inexorabletash much thanks! Ready to merge when the conflicts have been resolved. |
Contributor
Author
|
Resolved - @anssiko please double check and merge at your leisure! |
Member
|
Still looks as good as earlier and the build is 🟢 so... let's squash and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #555 (comment)
While making this change (which was mostly automated) I noticed a handful of very intertwined glitches; I included fixes as separate commits in this PR, to avoid too many PRs. They are:
I can split them out if desired.
Preview | Diff