Resolve todo in Boolean coercion, add explanation, update test names to match reference implementation#511
Merged
vladar merged 1 commit intowebonyx:masterfrom Jul 1, 2019
spawnia:scalar-coercion
Merged
Resolve todo in Boolean coercion, add explanation, update test names to match reference implementation#511vladar merged 1 commit intowebonyx:masterfrom spawnia:scalar-coercion
vladar merged 1 commit intowebonyx:masterfrom
spawnia:scalar-coercion
Conversation
…to match reference implementation
simPod
approved these changes
Jun 24, 2019
vladar
reviewed
Jul 1, 2019
| // Type System: Scalar coercion | ||
| /** | ||
| * @see it('serializes output int') | ||
| * @see it('serializes output as Int') |
Member
There was a problem hiding this comment.
I suggest not to change it annotations because they are basically IDs for the reference implementation test cases. You can copy contents of this annotation and quickly find a related test in the reference implementation. That's the only reason for their existence.
Member
There was a problem hiding this comment.
Oh, ignore %) I see that they've changed those in the reference implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.