Enhance type definitions for Executor#720
Merged
vladar merged 2 commits intowebonyx:masterfrom Sep 16, 2020
spawnia:executor-types
Merged
Enhance type definitions for Executor#720vladar merged 2 commits intowebonyx:masterfrom spawnia:executor-types
vladar merged 2 commits intowebonyx:masterfrom
spawnia:executor-types
Conversation
Contributor
|
Pretty keen! 👍 No changes to the baseline file..? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I converted Executor and ReferenceExecutor to use native type hints where possible and cleaned up a few mismatched types. Turns out a few of them, if translated 1-1, caused type errors.
Now we can be sure the types are correct and will have an easier time when trying to understand what is happening in the code and when refactoring.