fix $debug type in StandardServer::send500Error()#722
Merged
vladar merged 2 commits intowebonyx:masterfrom Sep 16, 2020
survilla:patch-1
Merged
fix $debug type in StandardServer::send500Error()#722vladar merged 2 commits intowebonyx:masterfrom survilla:patch-1
vladar merged 2 commits intowebonyx:masterfrom
survilla:patch-1
Conversation
`$debug` should be `int` in the same way as in definition of the `FormattedError::createFromException()`
spawnia
approved these changes
Aug 28, 2020
Collaborator
spawnia
left a comment
spawnia
left a comment
There was a problem hiding this comment.
The change makes sense, I would go ahead and convert to proper type hints.
| * @api | ||
| */ | ||
| public static function send500Error($error, $debug = false, $exitWhenDone = false) | ||
| public static function send500Error($error, $debug = DebugFlag::NONE, $exitWhenDone = false) |
Collaborator
There was a problem hiding this comment.
Suggested change
| public static function send500Error($error, $debug = DebugFlag::NONE, $exitWhenDone = false) | |
| public static function send500Error(Throwable $error, int $debug = DebugFlag::NONE, bool $exitWhenDone = false): void |
simPod
approved these changes
Sep 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$debuginStandardServer::send500Error()should beintin the same way as in definition of theFormattedError::createFromException()