Fix AST::fromArray conversion of initial values (match initial to expected conversion)#724
Merged
vladar merged 2 commits intowebonyx:masterfrom Sep 16, 2020
Conversation
…ected conversion) - Parse `DirectiveDefinitionNode->locations` as `NodeList<NamedNode>` - Parse `Parser::implementsInterfaces` as `NodeList<NamedTypeNode>` - Update signature of `Parser::unionMemberTypes` to match actual `NodeList<NamedTypeNode>` Fixes webonyx#723
spawnia
approved these changes
Aug 31, 2020
Collaborator
spawnia
left a comment
There was a problem hiding this comment.
This makes the Parser more self-consistent, looks good to me.
Contributor
Author
|
Thanks @spawnia. I removed instead of updated the |
Contributor
Author
|
@spawnia It looks like phpcs marks those as duplicate information errors 😞 Should I remove them again, or is there something I could do in PHPCS to allow for them? |
Collaborator
Maybe we can fix that in the future, let's remove it for now to keep this PR focused. |
d3dc845 to
3373240
Compare
Contributor
Author
|
Done 👍 Thanks! |
simPod
approved these changes
Sep 11, 2020
Member
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DirectiveDefinitionNode->locationsasNodeList<NamedNode>Parser::implementsInterfacesasNodeList<NamedTypeNode>Parser::unionMemberTypesto match actualNodeList<NamedTypeNode>Fixes #723
Note: I wasn't sure how to address the phpstan error so I updated the baseline. I can revisit this if necessary.