Fixed SchemaPrinter so that it uses late static binding#747
Merged
vladar merged 1 commit intowebonyx:masterfrom Dec 3, 2020
Merged
Fixed SchemaPrinter so that it uses late static binding#747vladar merged 1 commit intowebonyx:masterfrom
vladar merged 1 commit intowebonyx:masterfrom
Conversation
spawnia
approved these changes
Dec 3, 2020
Collaborator
spawnia
left a comment
spawnia
left a comment
There was a problem hiding this comment.
That opens the door for easier extensibility, nice.
simPod
approved these changes
Dec 3, 2020
Contributor
Author
|
@spawnia when can I expect this to be merged/published? |
Collaborator
|
We typically wait for @vladar to show up and merge. This is a small change which I do feel confident about including, but so far that has been our modus operandi. |
spawnia
changed the title
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making class methods protected isn't enough to be able to override them, because all of them call each other using
self::notstatic::