Reify AST node types and remove unneeded nullability#751
Merged
vladar merged 10 commits intowebonyx:masterfrom Jan 23, 2021
spawnia:reify-ast-node-types
Merged
Reify AST node types and remove unneeded nullability#751vladar merged 10 commits intowebonyx:masterfrom spawnia:reify-ast-node-types
vladar merged 10 commits intowebonyx:masterfrom
spawnia:reify-ast-node-types
Conversation
This achieves a few things: - make the code easier to understand both by humans and static analyzers - improve performance by eliminating unnecessary null checks - improve usability through a clarified API
3 tasks
Co-authored-by: Simon Podlipsky <simon@podlipsky.net>
spawnia
commented
Jan 5, 2021
vladar
approved these changes
Jan 23, 2021
Member
vladar
left a comment
vladar
left a comment
There was a problem hiding this comment.
Nice change 👍 But do you think it is safe to publish as a patch? I am a bit hesitant. Inclining to include it in the next minor.
Collaborator
Author
|
The actual code changes are very minor and would be best classified as bug fixes. If anything, it would uncover implementations which are already bugged in some way. |
Member
|
We have conflicts now after merging #740. Mind fixing? Then we can ship it and safely publish it in the new minor 🚢 |
# Conflicts: # src/Language/AST/InterfaceTypeDefinitionNode.php # src/Language/AST/InterfaceTypeExtensionNode.php # src/Utils/ASTDefinitionBuilder.php
Collaborator
Author
|
@vladar done 🚢 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This achieves a few things: