fix query plan for wrapped types#756
Merged
vladar merged 1 commit intowebonyx:masterfrom Jan 23, 2021
Merged
Conversation
crissi
force-pushed
the
fix_query_plan_for_wrapped_types
branch
from
0aa086d to
8492715
Compare
spawnia
requested changes
Dec 17, 2020
crissi
force-pushed
the
fix_query_plan_for_wrapped_types
branch
2 times, most recently
from
2f92a5d to
9508631
Compare
spawnia
reviewed
Dec 18, 2020
spawnia
approved these changes
Dec 18, 2020
simPod
approved these changes
Dec 18, 2020
crissi
force-pushed
the
fix_query_plan_for_wrapped_types
branch
from
38d5cf6 to
b08ce20
Compare
Collaborator
|
The implementation of is fine, but i would like @vladar to confirm that this is indeed how the query plan should behave for wrapped types. |
vladar
approved these changes
Jan 23, 2021
Member
vladar
left a comment
vladar
left a comment
There was a problem hiding this comment.
Agree, this is a valid bugfix! Thanks! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was getting error: "Call to undefined method GraphQL\Type\Definition\ListOfType::getField()" when using QueryPlan::lookAhead()