Do not add errors key when empty#766
Merged
vladar merged 4 commits intowebonyx:masterfrom Jan 23, 2021
lingoda:no-empty-errors
Merged
Do not add errors key when empty#766vladar merged 4 commits intowebonyx:masterfrom lingoda:no-empty-errors
vladar merged 4 commits intowebonyx:masterfrom
lingoda:no-empty-errors
Conversation
spawnia
reviewed
Jan 13, 2021
spawnia
reviewed
Jan 13, 2021
spawnia
reviewed
Jan 13, 2021
Collaborator
spawnia
left a comment
spawnia
left a comment
There was a problem hiding this comment.
I just added some minutiae for clarity, the change makes sense to me.
Contributor
Author
Thank you, done both. |
simPod
reviewed
Jan 14, 2021
simPod
reviewed
Jan 14, 2021
Co-authored-by: Simon Podlipsky <simon@podlipsky.net>
simPod
approved these changes
Jan 14, 2021
Collaborator
simPod
left a comment
simPod
left a comment
There was a problem hiding this comment.
Just checked and complies with spec 👍🏾
Contributor
Author
|
Can we merge and tag this? |
Kingdutch
reviewed
Jan 23, 2021
Comment on lines
+150
to
+153
| // While we know that there were errors initially, they might have been discarded | ||
| if ($handledErrors !== []) { | ||
| $result['errors'] = $handledErrors; | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Collaborator
There was a problem hiding this comment.
Handling the errors could also mean to translate the messages, format them nicely, whatever!
Contributor
There was a problem hiding this comment.
Ah I see :D Yeah then I suppose it makes sense 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the error handler filters out all the errors so that none remains, we should not add the errors key to the result.