Allow pushing nodes to NodeList via []=#767
Merged
vladar merged 6 commits intowebonyx:masterfrom Jan 23, 2021
spawnia:allow-pushing-to-node-list
Merged
Allow pushing nodes to NodeList via []=#767vladar merged 6 commits intowebonyx:masterfrom spawnia:allow-pushing-to-node-list
vladar merged 6 commits intowebonyx:masterfrom
spawnia:allow-pushing-to-node-list
Conversation
This can come up when manipulating the AST programmatically. When pushing to a `NodeList` using `[]=`, the first argument to `offsetExists` is `null`. Thus, the element is set into the internal array with `(string) null === ""`. Now, additional pushes replace the node at key `""` instead of appending as expected.
This was referenced Jan 20, 2021
simPod
approved these changes
Jan 20, 2021
Collaborator
Author
|
@vladar can i merge this and cut a bugfix release? Just ran into this bug in Lighthouse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can come up when manipulating the AST programmatically.
When pushing to a
NodeListusing[]=, the first argumentto
offsetExistsisnull.Thus, the element is set into the internal array with
(string) null === "".Now, additional pushes replace the node at key
""instead of appending as expected.