This repository was archived by the owner on Sep 9, 2021. It is now read-only.
refactor(loader) v2.0.0 #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwiens
changed the title
Contributor
|
Some targets are no longer available in webpack 4:
|
michael-ciniawsky
changed the title
Contributor
|
I've open a PR (webpack/webpack#6368) to expose the required internal plugins. In v2, you should drop the hot-linking of internal dependencies. This may prevent having a build step on webpack. |
|
Checking in on when we can merge this and #121 |
|
Really could do with this merge going ahead. Holding my team back from moving to Webpack 4.X. |
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=========================================
Coverage ? 66.21%
=========================================
Files ? 5
Lines ? 74
Branches ? 25
=========================================
Hits ? 49
Misses ? 22
Partials ? 3Continue to review full report at Codecov.
|
shellscape
approved these changes
Apr 6, 2018
TheLD6978
pushed a commit
to TheLD6978/worker-loader
that referenced
this pull request
Apr 16, 2021
refactor(loader) v2.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Sets
enginesto"node": ">= 6.9.0 || >= 8.9.0"BREAKING CHANGE: Drops support for Webpack
v2.x