Switch to tinyglobby

[benmccann]

Modification Proposal

Switch from globby to tinyglobby.

tinyglobby has quickly been adopted by vite and a number of other major projects as a much smaller near drop-in replacement for globby.

The main challenge with adopting it in this library is that the globby constructor options are directly exposed as an option here and the tinyglobby constructor options type is different, so it would be a breaking change that would have to be done in a major release.

Expected Behavior / Situation

https://npmgraph.js.org/?q=tinyglobby - 2 dependencies

Actual Behavior / Situation

https://npmgraph.js.org/?q=globby - 23 dependencies

Please paste the results of npx webpack-cli info here, and mention other relevant information

n/a

[evenstensberg]

Sounds good. I also think we can remove external libraries for globbing once we reach to the point that the lowest nodejs version supported allows us to use the native node glob.

Send a PR!

[benmccann]

I've made a lot of progress on this. It seems that absolute: true needs to be set. It appears that globby has some bug that tinyglobby doesn't because the default is false, but globby seems to be returning absolute paths anyway. We need to set absolute: true to have tinyglobby also return absolute paths. Nearly all the tests pass once that's done. There's still one last issue I have to investigate

[alexander-akait]

@benmccann Feel free to feedback if you will have questions

[benmccann]

This might be blocked by tinyglobby adding support for the fs option: SuperchupuDev/tinyglobby#81

[alexander-akait]

We can add it without this option and check perf

[benmccann]

Okay, great! I will fix the last test and send a PR then

[Juraj-Masiar]

Hello,
I'm trying to upgrade to new version 13.0.0 but it's failing due to this breaking change and the text in the release notes is not clear enough about what to do actually.
This is my super simple usecase:

new CopyPlugin({
  patterns: [
    { from: browser,  to: '', globOptions: { ignore: ['**.ts', '**.git'] } },
    { from: 'src',    to: '', globOptions: { ignore: ['**.ts', '**.html', '**.git', '**.js', '**.vue', '**.sh'] } },
  ],
}),

Can you please help me update it?

[benmccann]

Can you give more details about how it's failing? What is the behavior you're getting vs the behavior you're expecting? If you could provide a repository that reproduces your issue that would also be helpful