Skip to content

Refactor migrate on mkdir#499

Merged
hiroppy merged 1 commit into
nextfrom
refactor-migrate-on-mkdir
Nov 6, 2019
Merged

Refactor migrate on mkdir#499
hiroppy merged 1 commit into
nextfrom
refactor-migrate-on-mkdir

Conversation

@alexander-akait
Copy link
Copy Markdown
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Remove unnecessary dep

Breaking Changes

No

Additional Info

Because we support only >= 10.13 we can safely use this method

@alexander-akait alexander-akait changed the base branch from master to next October 29, 2019 13:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 29, 2019

Codecov Report

Merging #499 into next will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #499   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files          11       11           
  Lines         284      284           
  Branches      100      100           
=======================================
  Hits          275      275           
  Misses          9        9
Impacted Files Coverage Δ
src/utils/setupWriteToDisk.js 91.89% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 869f58a...0fddfcc. Read the comment docs.

@hiroppy hiroppy merged commit 32991b0 into next Nov 6, 2019
@hiroppy hiroppy deleted the refactor-migrate-on-mkdir branch November 6, 2019 00:06
hiroppy pushed a commit that referenced this pull request Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants