Use built version os sockjs-client

[filipesilva]

What kind of change does this PR introduce?

Bugfix

Did you add or update the examples/?
Yes.

Summary

webpack-dev-server bundles sockjs-client from source. sockjs-client sources assume a node environment however, and will fail to run if global is not available.

By bundling sockjs-client from source, the node environment requirement from sockjs-client will also be required of the app being served and thus it is not possible to have node.global = false in the user app being bundled.

This fix uses the built sockjs-client instead of the sources.

Does this PR introduce a breaking change?

No.

Other information
Fix #1147

[codecov]

Codecov Report

Merging #1148 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1148   +/-   ##
======================================
  Coverage    76.8%   76.8%           
======================================
  Files           5       5           
  Lines         470     470           
  Branches      151     151           
======================================
  Hits          361     361           
  Misses        109     109

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32412bb...fe5e48c. Read the comment docs.

[shellscape]

these are more for "how to" for users, but there's no harm in adding this. the tests that matter are in /test. no worries if you can't get to adding one there, we can do it after merging.

[filipesilva]

@shellscape I removed the example, I don't think it's a real user example.

Regarding the real tests in /test, to test node: false doesn't throw a runtime error, a e2e test would be needed. It looks like there is no test where a browser is actually used. Instead I added node: false to the simple config to ensure that stuff in general still works with it, and that it's not needed for normal webpack-dev-server functioning. WDYT?

[shellscape]

Yeah good point; we would actually need a browser for this. I'd leave the example in there as a means to test that change at the moment, even though it's not a traditional example. We can look into headless browser testing for the client in the future.

[filipesilva]

Done, re-added it.

[shellscape]

Thanks much :)

[filipesilva]

Thank you for the quick review!