feat(Server): add sockJsUrl option (options.sockJsUrl)#1335
Closed
freememory wants to merge 2 commits intowebpack:masterfrom
Closed
feat(Server): add sockJsUrl option (options.sockJsUrl)#1335freememory wants to merge 2 commits intowebpack:masterfrom
sockJsUrl option (options.sockJsUrl)#1335freememory wants to merge 2 commits intowebpack:masterfrom
Conversation
|
|
michael-ciniawsky
changed the title
sockJsUrl option (options.sockJsUrl)
Contributor
|
Closing in favor of #1553. Thx :) |
michael-ciniawsky
added
status: declined
and removed
pr: review
severity: 4 (inconvenient)
status: pending
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Currently, sockjs-node is the hardcoded sockjs path. However, in some environments it's desirable to be able to set what the sockjs path is, if it already exists (and is difficult to change). Allow users to specify the url as an arg.
Breaking Changes
N/A
Additional Info