Merged
Conversation
41dfc02 to
8c14159
Compare
Member
Author
|
CI got results as expected below. This is already fixed by #1736 so I want to merge this pr even if CI failed. |
daf2841 to
7b28d26
Compare
7b28d26 to
42ea465
Compare
Member
|
/cc @hiroppy need rebase 👍 |
42ea465 to
60574e0
Compare
Member
Author
|
/cc @evilebottnawi rebased. PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
no
Motivation / Use-Case
Run v2 on Travis.
Breaking Changes
no
Additional Info