Skip to content

fix: filter deleted assets in processAdditionalAssets hook#19751

Merged
alexander-akait merged 1 commit intomainfrom
fix/lint_processAdditionalAssets
Jul 30, 2025
Merged

fix: filter deleted assets in processAdditionalAssets hook#19751
alexander-akait merged 1 commit intomainfrom
fix/lint_processAdditionalAssets

Conversation

@xiaoxiaojx
Copy link
Member

@xiaoxiaojx xiaoxiaojx commented Jul 29, 2025

What kind of change does this PR introduce?
Fixes webpack/compression-webpack-plugin#390

The original commit that fixed the issue is d2d34e6. This PR is only for fixing lint issues and verifying test case execution.

Image

Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
No

@xiaoxiaojx xiaoxiaojx force-pushed the fix/lint_processAdditionalAssets branch 2 times, most recently from 913dcbc to 78bdbb6 Compare July 29, 2025 20:41
@xiaoxiaojx xiaoxiaojx force-pushed the fix/lint_processAdditionalAssets branch from 78bdbb6 to 953d2cc Compare July 29, 2025 20:45
@xiaoxiaojx xiaoxiaojx changed the title fix: lint fix: filter deleted assets in processAdditionalAssets hook Jul 29, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 29, 2025

CodSpeed Performance Report

Merging #19751 will improve performances by 58.43%

Comparing fix/lint_processAdditionalAssets (953d2cc) with main (d2d34e6)

Summary

⚡ 4 improvements
✅ 38 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
benchmark "devtool-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 114.5 ms 79.5 ms +44.12%
benchmark "many-chunks-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 124.4 ms 92.6 ms +34.39%
benchmark "many-chunks-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 145.7 ms 98.1 ms +48.53%
benchmark "three-long", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 351.1 ms 221.6 ms +58.43%

@alexander-akait alexander-akait merged commit de79ee4 into main Jul 30, 2025
44 checks passed
@alexander-akait alexander-akait deleted the fix/lint_processAdditionalAssets branch July 30, 2025 10:12
@alexander-akait
Copy link
Member

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: deleteOrigianlAssets: true breaks the build badly...

2 participants