This repository was archived by the owner on Feb 24, 2022. It is now read-only.
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 4.0.1 of sinon just got published.
The version 4.0.1 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of sinon.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 16 commits.
ec9126cUpdate docs/changelog.md and set new release id in docs/_config.yml1222a0fAdd release documentation for v4.0.11bf1f2d4.0.11545c26Update History.md and AUTHORS for new releasee9fab2dMerge pull request #1579 from fatso83/upgrade-depsf2252b4Upgrade nise and lolex versionsd81a937Fix doc typo: scenarious -> scenariosaf3a645Merge pull request #1577 from evan-007/fix_doc_typo7c9c881Remove extra backtick from fake-xhr-and-server docscf9bf05Merge pull request #1575 from mroderick/tidy-up-docs2e8abadRemove obsoleted lib/sinon/sandbox-stub.js28e70d1Use an include for migration guides3c68adcMove migration guides to new section6197ff3Merge pull request #1565 from fatso83/patch-docsdfb9ee6Add migration guide for 4.0There are 16 commits in total.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴