Merged
Conversation
Covers accordion, alert-dialog, button-group, collapsible, field, input-group, popover, resizable, scroll-area, separator, sheet, sidebar, skeleton, slider, toast, and table. Defines dependency-first build order, token additions, component APIs, testing and story strategy.
Implements Popover with PopoverTrigger, PopoverContent, and PopoverClose using @base-ui/react/popover. Also adds optimizeDeps.include entries to vitest.config.ts to prevent mid-run Vite reloads for new Base UI sub-packages.
Implements Slider built on @base-ui/react/slider with Control, Track, Indicator, and Thumb sub-components. Test for min/max uses native HTML attributes (not aria-valuemin/max) since Base UI uses a hidden input[type=range].
Also adds @base-ui/react/collapsible, /accordion, /alert-dialog to vitest optimizeDeps to fix React duplicate-instance error in browser tests.
Accessible form field with label, description, error message, fieldset, and layout helpers using Base UI Field/Fieldset primitives.
Implements the Sidebar component with context-based state management, mobile Sheet mode, collapsible icon/offcanvas modes, Tooltip integration for collapsed hints, and Separator/Skeleton sub-components. Also fixes TooltipTrigger to expose the render prop, and sets the test viewport to 1280x720 to ensure sidebar tests run in desktop mode.
Add exports for all 16 new components to packages/registry/src/index.ts, create the missing lib/cx.ts utility, and fix a sidebar state type annotation.
…-group, input-group
…dialog, sheet, resizable, toast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the following components: