-
Notifications
You must be signed in to change notification settings - Fork 67
Open
Description
We spotted issue that there is no possibility to place order because missing shipping method.
Step to reproduce
- Configure different matrix
| Country | Region/State | City | Zip/Postal Code From | Zip/Postal Code To | Order Subtotal > | Order Subtotal <= | Shipping Price |
|---|---|---|---|---|---|---|---|
| CHE | * | * | * | * | -1.0000 | 59.9900 | 6.5000 |
| CHE | * | * | * | * | -1.0000 | 59.9900 | 9.0000 |
| CHE | * | * | * | * | 59.9900 | 99999999.9999 | 0.0000 |
| CHE | * | * | * | * | 59.9900 | 99999999.9999 | 2.5000 |
- Add product to the cart which is more expensive than 60 euro
- go to the last step
- choose payment method
- apply coupon code with free shipping
- try to place order
- you can find in logs that the shipping method is not set
The issue comes from the below code:
vendor/webshopapps/module-matrixrate/src/Model/Carrier/Matrixrate.php?ref_type=heads#L152
} elseif ($item->getFreeShipping()) {
$freeShipping = is_numeric($item->getFreeShipping()) ? $item->getFreeShipping() : 0;
$freeQty += $item->getQty() - $freeShipping;
$freePackageValue += $item->getBaseRowTotal();
}If I removed it shipping method is not reseted and order is able to be placed
Metadata
Metadata
Assignees
Labels
No labels