Skip to content

[minor] allow overriding default duplex stream options for createWebSocketStream #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lpinca merged 3 commits into from
Oct 14, 2019
Merged

[minor] allow overriding default duplex stream options for createWebSocketStream #1647

lpinca merged 3 commits into from
Oct 14, 2019

Conversation

@tadeuszwojcik
Copy link
Contributor

@tadeuszwojcik tadeuszwojcik commented Oct 11, 2019

closes #1640

lpinca
lpinca reviewed Oct 11, 2019
View reviewed changes
lpinca
lpinca reviewed Oct 11, 2019
View reviewed changes
lpinca
lpinca reviewed Oct 11, 2019
View reviewed changes
@lpinca lpinca merged commit 2b7d84d into websockets:master Oct 14, 2019
@lpinca
Copy link
Member

lpinca commented Oct 14, 2019

Thank you.

@tadeuszwojcik
Copy link
Contributor Author

tadeuszwojcik commented Oct 14, 2019

Thanks!

@tadeuszwojcik
Copy link
Contributor Author

tadeuszwojcik commented Oct 17, 2019

Do you have rough idea when those changes will be published to NPM? Currently using version from #master but would like to plan migration to stable v7.x, thanks!

@lpinca
Copy link
Member

lpinca commented Oct 19, 2019 •
edited
Loading

ws@7.2.0 was released a few minutes ago.

@tadeuszwojcik
Copy link
Contributor Author

tadeuszwojcik commented Oct 21, 2019

Great! Thank you!

@snyk-bot snyk-bot mentioned this pull request Oct 30, 2019
Merged
This was referenced Nov 10, 2019
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 2, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 27, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 15, 2020
Closed
akhdaniel pushed a commit to akhdaniel/ws that referenced this pull request Jul 5, 2025
@tadeuszwojcik
[minor] Add ability to specify the readableObjectMode option (webso…
e940477 
…ckets#1647)
akhdaniel pushed a commit to akhdaniel/ws that referenced this pull request Jul 5, 2025
@tadeuszwojcik
[minor] Add ability to specify the readableObjectMode option (webso…
674e104 
…ckets#1647)
This was referenced Oct 23, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

createWebSocketStream - objectMode

2 participants

@tadeuszwojcik @lpinca