[fix] Allow close code 1014 #1682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IANA has assigned 1014 as "Bad Gateway" https://www.iana.org/assignments/websocket/websocket.xhtml#close-code-number https://developer.mozilla.org/en-US/docs/Web/API/CloseEvent ws support for 1012, and 1013 was added in b58f688
lpinca
approved these changes
Jan 21, 2020
Member
lpinca
left a comment
lpinca
left a comment
There was a problem hiding this comment.
LGTM even though browsers only allow 1000 or >=3000 && <= 4999
Member
|
Thank you. |
This was referenced Mar 27, 2020
This was referenced Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IANA has assigned 1014 as "Bad Gateway"
https://www.iana.org/assignments/websocket/websocket.xhtml#close-code-number
https://developer.mozilla.org/en-US/docs/Web/API/CloseEvent
ws support for 1012, and 1013 was added in b58f688