Skip to content

Conversation

@cbfiddle
Copy link

No description provided.

@weisJ
Copy link
Owner

weisJ commented Nov 13, 2023

Please either restore the git submodule to the openjdk repo or include the JNF framework sources explicitly.

@weisJ
Copy link
Owner

weisJ commented Nov 21, 2023

There are still paths that reference the openjdk directory. Please also remove the .gitmodules file as the submodule has been removed. This currently doesn't build please make sure that gradlew buildJNF runs successfully.

Also I am unsure about the manual build script build_jnf2.sh. There really aren't any hard requirements to keep the macOS target version at the current version. I'd rather bump it and use xcodebuild again. This way we don't have to manually replicate a correct framework folder layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants